Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for projects and starter projects #360

Merged
merged 4 commits into from
Mar 4, 2021
Merged

add tests for projects and starter projects #360

merged 4 commits into from
Mar 4, 2021

Conversation

mmulholla
Copy link
Contributor

Add test for projects and starter project to the new api test.
The code added will be shared with the library tests.

@mmulholla mmulholla requested a review from maysunfaisal March 1, 2021 18:26
johnmcollier
johnmcollier requested changes Mar 3, 2021
View reviewed changes
Copy link
Member

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you're making a lot of calls to generate random strings and numbers. My concern is that it could make the api test results non-reproducible between runs.

Wondering also if we need to test the GitHub project type now that it's been deprecated? (#349)

test/v200/utils/common/project_test_utils.go Show resolved Hide resolved
test/v200/utils/common/project_test_utils.go Show resolved Hide resolved
test/v200/utils/common/project_test_utils.go Outdated Show resolved Hide resolved
@mmulholla
Copy link
Contributor Author

@johnmcollier I added an extra commit because the starter projects I was creating failed validation because they are restricted to one remote.

maysunfaisal
maysunfaisal approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@maysunfaisal maysunfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, follows the existing test convention.

test/v200/utils/common/project_test_utils.go Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johnmcollier, maysunfaisal, mmulholla
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@mmulholla mmulholla merged commit bfc3f50 into devfile:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maysunfaisal maysunfaisal maysunfaisal approved these changes

@johnmcollier johnmcollier johnmcollier approved these changes

@amisevsk amisevsk Awaiting requested review from amisevsk

@davidfestal davidfestal Awaiting requested review from davidfestal

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

Assignees

@johnmcollier johnmcollier

@maysunfaisal maysunfaisal

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmulholla @openshift-ci-robot @johnmcollier @maysunfaisal